michael/lean2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6171 commits 3 branches 0 tags 28 MiB
Commit graph

6171 commits

This branch
This branch
All branches
Author SHA1 Message Date
Soonho Kong
a2a5a77a44 fix(memory): increase memory counters by the actual size of reallocated memory 
On OSX, we had a test failure on memory module. The problem was in
the realloc function (line 38):

    void * realloc(void * ptr, size_t sz) {
        size_t old_sz = malloc_size(ptr);
        g_global_memory.dec(old_sz);
        g_global_memory.inc(sz);
        g_thread_memory.dec(old_sz);
        g_thread_memory.inc(sz);
        void * r = realloc_core(ptr, sz);
        if (r || sz == 0)
            return r;
        else
            ...

The size of r could be bigger than sz. For instance,

    |ptr| = 40 but |r| = 48

In the current code, here we only increase counters by 40.
But later when we free it, we decrease them by 48, and this
caused the problem, underflow of an unsigned counter in
g_global_memory.
 2013-09-26 00:33:56 -07:00
Leonardo de Moura
4bae715350 fix(memory): disable problematic test when tcmalloc is used 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 22:39:49 -07:00
Leonardo de Moura
c00534209a test(splay_map): add tests for improving code coverage 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 22:12:49 -07:00
Leonardo de Moura
98b4e09063 refactor(kernel): simplify expr_eq 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 22:09:08 -07:00
Leonardo de Moura
23e2f72f42 test(list): add tests for improving code coverage 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 22:04:24 -07:00
Leonardo de Moura
db4e5ab0ad feat(expr_lt): improve expr_lt performance by using hash codes, and add more tests 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 21:59:58 -07:00
Leonardo de Moura
6477708d78 refactor(debug): improve lean_unreachable(), now we can avoid 'fake' return statements 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 21:27:20 -07:00
Leonardo de Moura
a7707dd669 test(bit_tricks): add tests for log2 2013-09-25 20:58:01 -07:00
Leonardo de Moura
44a16cab6a test(exception): add new tests exception and parser_exception 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 20:57:53 -07:00
Leonardo de Moura
87e749cd12 test(trace): add unit test for trace module 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 20:30:05 -07:00
Leonardo de Moura
e16f45854b refactor(deep_copy): simplify deep_copy implementation, and move unit test to separate file 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 20:25:24 -07:00
Leonardo de Moura
037ebfd1d4 refactor(util): make 'util/test.h' the first include 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 20:13:05 -07:00
Soonho Kong
6aec85e6c2 doc(commit_convention): add git commit_convention 2013-09-25 19:45:15 -07:00
Soonho Kong
70e7bcd9e4 doc(coding_style): rename style.md to coding_style.md 2013-09-25 19:45:15 -07:00
Soonho Kong
ad62f9762b fix(tests/util): use lean_assert_eq 2013-09-25 19:22:36 -07:00
Soonho Kong
475338080f fix(tests/interval): use new lean_assert and lean_assert_eq 2013-09-25 18:40:45 -07:00
Leonardo de Moura
9f0dab1add fix(kernel): add declarations for operator<<(std::ostream&, expr const&) and operator<<(std::ostream&, context const&) in the kernel 
The actual implementation of these two operators is outside of the
kernel. They are implemented in the file 'library/printer.cpp'.
We declare them in the kernel to prevent the following problem.
Suppose there is a file 'foo.cpp' that does not include
'library/printer.h', but contains

    expr a;
    ...
    std::cout << a << "\n";
    ...

The compiler does not generate an error message. It silently uses the
operator bool() to coerce the expression into a Boolean. This produces
counter-intuitive behavior, and may confuse developers.
 2013-09-25 17:45:54 -07:00
Soonho Kong
4a66712ef2 doc(style): update C++ style guide 2013-09-25 17:44:27 -07:00
Leonardo de Moura
1452e9319e feat(debug): improve lean_assert macro 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-25 17:29:00 -07:00
Soonho Kong
1d8b7dc193 Update 'orelse' and 'then' rewriter to take a list of rewriters 2013-09-25 16:46:39 -07:00
Soonho Kong
a50f5f92b8 Rename 'rewrite' to 'Rewriter', change type of rewriter::operator() 2013-09-25 15:38:16 -07:00
Soonho Kong
573ca92a08 Fix typo in CTestConfig.cmake 2013-09-24 21:46:51 -07:00
Soonho Kong
6d10e978dc Add "--gen-suppressions=all" to valgrind option 2013-09-24 21:36:03 -07:00
Soonho Kong
0ef633a3c5 Fix to be compiled by clang++-3.4 
Clang++-3.4 is starting to enforce the following item of C++11 standard,
thus it's making lean not compiling:

It's illegal in C++11: §8.3.6.4 [dcl.fct.default]
"If a friend declaration specifies a default argument expression, that
declaration shall be a definition and shall be the only declaration of
the function or function template in the translation unit."
 2013-09-24 21:30:56 -07:00
Soonho Kong
8e9bd9ee67 Add Repeat/Success/Fail to rewrite (skeleton) 2013-09-24 20:04:08 -07:00
Soonho Kong
ac0eafa1b6 Fix style-warning 2013-09-24 19:34:58 -07:00
Soonho Kong
57e9e2c658 Re-implement rewrite module using rewrite_cell 2013-09-24 19:11:09 -07:00
Leonardo de Moura
ba0528c298 Implement total order on expressions 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-24 12:16:32 -07:00
Leonardo de Moura
e23813f15d Add support for creating unique internal names. 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-24 11:01:30 -07:00
Leonardo de Moura
1779b29355 Implement map using splay_trees 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-24 01:44:46 -07:00
Soonho Kong
71fb150333 Fix type of rewrite() to take an env. Add skeletons for other rewriters 2013-09-24 01:20:45 -07:00
Soonho Kong
81c9de229b Add then and orelse rewrite combinators and tests 2013-09-24 01:19:03 -07:00
Soonho Kong
9ba6068858 Update fo_match 2013-09-24 01:19:03 -07:00
Soonho Kong
f89ededddc Add rewrite and first-order pattern matching skeletal 2013-09-24 01:19:03 -07:00
Leonardo de Moura
b78b2e0585 Add remaining splay tree methods 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-24 01:04:02 -07:00
Soonho Kong
01f5fa59b1 Update src/memcheck.supp to suppress warnings caused by tcmalloc 2013-09-24 03:58:13 -04:00
Leonardo de Moura
d31f3facac Implement splay trees 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-23 22:31:18 -07:00
Soonho Kong
c1b12eae99 Update memcheck.supp to suppress a valgrind warning caused by a bug in tcmalloc-2.0 2013-09-23 19:57:16 -07:00
Leonardo de Moura
46d6c41835 Fix bug in the type checker (when type checking terms with meta-variables). 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-22 19:12:19 -07:00
Leonardo de Moura
1647e44510 Fix memory corruption bug 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-22 18:53:58 -07:00
Leonardo de Moura
16a6a54df1 Fix abuse of operator-> overload 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-22 16:41:51 -07:00
Leonardo de Moura
c847d27763 Improve higher order unification 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-21 00:41:49 -07:00
Soonho Kong
80581a76bb Update Find{MSize,MallocSize,MallocUsableSize}.cmake to handle the case where find_path fails 2013-09-21 00:10:25 -07:00
Soonho Kong
48318511f2 Undo the previous change which caused compile-errors 2013-09-21 00:04:23 -07:00
Soonho Kong
66ba1a20d7 Suppress cmake warning for OSX build 2013-09-20 23:49:09 -07:00
Leonardo de Moura
d29ec9ab6f Add tests for memory.cpp 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-20 22:37:13 -07:00
Leonardo de Moura
7ac94ee976 Add max_sharing tests 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-20 22:01:40 -07:00
Leonardo de Moura
d34cfe3f8a Add simple formatter tests 
Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
 2013-09-20 21:46:32 -07:00
Soonho Kong
69269982cb Update .travis.osx.yml 
- make TCMALLOC explicit
[skip ci]
 2013-09-20 18:10:12 -07:00
Soonho Kong
bef44899c8 Suppress style warning on util/memory.cpp 2013-09-20 18:07:12 -07:00