691893258d
The new hash code has the property that given expr_cell * c1 and expr_cell * c2, if c1 != c2 then there is a high propbability that c1->hash_alloc() != c2->hash_alloc(). The structural hash code hash() does not have this property because we may have c1 != c2, but c1 and c2 are structurally equal. The new hash code is only compatible with pointer equality. By compatible we mean, if c1 == c2, then c1->hash_alloc() == c2->hash_alloc(). This property is obvious because hash_alloc() does not have side-effects. The test tests/lua/big.lua exposes the problem fixed by this commit. Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
51 lines
1.9 KiB
C++
51 lines
1.9 KiB
C++
/*
|
|
Copyright (c) 2013 Microsoft Corporation. All rights reserved.
|
|
Released under Apache 2.0 license as described in the file LICENSE.
|
|
|
|
Author: Leonardo de Moura
|
|
*/
|
|
#pragma once
|
|
#include <unordered_set>
|
|
#include <utility>
|
|
#include "util/hash.h"
|
|
#include "kernel/expr.h"
|
|
|
|
namespace lean {
|
|
|
|
// =======================================
|
|
// Expression Set && Expression Offset Set
|
|
// Remark: to expressions are assumed to be equal if they are "pointer-equal"
|
|
typedef std::unordered_set<expr, expr_hash_alloc, expr_eqp> expr_set;
|
|
typedef std::unordered_set<expr_offset, expr_offset_hash, expr_offset_eqp> expr_offset_set;
|
|
// =======================================
|
|
|
|
// =======================================
|
|
// (low level) Expression Cell Set
|
|
// Remark: to expressions are assumed to be equal if they are "pointer-equal"
|
|
//
|
|
// WARNING: use with care, this kind of set
|
|
// does not prevent an expression from being
|
|
// garbage collected.
|
|
typedef std::unordered_set<expr_cell*, expr_cell_hash, expr_cell_eqp> expr_cell_set;
|
|
typedef std::unordered_set<expr_cell_offset, expr_cell_offset_hash, expr_cell_offset_eqp> expr_cell_offset_set;
|
|
// =======================================
|
|
|
|
// =======================================
|
|
// (low level) Expression Cell pair Set
|
|
// Remark: to expressions are assumed to be equal if they are "pointer-equal"
|
|
//
|
|
// WARNING: use with care, this kind of set
|
|
// does not prevent an expression from being
|
|
// garbage collected.
|
|
typedef std::pair<expr_cell *, expr_cell *> expr_cell_pair;
|
|
struct expr_cell_pair_hash {
|
|
unsigned operator()(expr_cell_pair const & p) const { return hash(p.first->hash_alloc(), p.second->hash_alloc()); }
|
|
};
|
|
struct expr_cell_pair_eqp {
|
|
bool operator()(expr_cell_pair const & p1, expr_cell_pair const & p2) const {
|
|
return p1.first == p2.first && p1.second == p2.second;
|
|
}
|
|
};
|
|
typedef std::unordered_set<expr_cell_pair, expr_cell_pair_hash, expr_cell_pair_eqp> expr_cell_pair_set;
|
|
// =======================================
|
|
}
|