f80106a895
operator bool() may produce unwanted conversions. For example, we had the following bug in the code base. ... object const & obj = find_object(const_name(n)); if (obj && obj.is_builtin() && obj.get_name() == n) ... obj.get_name() has type lean::name n has type lean::expr Both have 'operator bool()', then the compiler uses the operator to convert them to Boolean, and then compare the result. Of course, this is not our intention. After this commit, the compiler correctly signs the error. The correct code is ... object const & obj = find_object(const_name(n)); if (obj && obj.is_builtin() && obj.get_name() == const_name(n)) ... Signed-off-by: Leonardo de Moura <leonardo@microsoft.com>
24 lines
1.1 KiB
C++
24 lines
1.1 KiB
C++
/*
|
|
Copyright (c) 2013 Microsoft Corporation. All rights reserved.
|
|
Released under Apache 2.0 license as described in the file LICENSE.
|
|
|
|
Author: Leonardo de Moura
|
|
*/
|
|
#include "kernel/occurs.h"
|
|
#include "kernel/find_fn.h"
|
|
|
|
namespace lean {
|
|
bool occurs(name const & n, context const * c, unsigned sz, expr const * es) {
|
|
return static_cast<bool>(find(c, sz, es, [&](expr const & e) { return is_constant(e) && const_name(e) == n; }));
|
|
}
|
|
|
|
bool occurs(expr const & n, context const * c, unsigned sz, expr const * es) {
|
|
return static_cast<bool>(find(c, sz, es, [&](expr const & e) { return e == n; }));
|
|
}
|
|
bool occurs(expr const & n, expr const & m) { return occurs(n, nullptr, 1, &m); }
|
|
bool occurs(name const & n, expr const & m) { return occurs(n, nullptr, 1, &m); }
|
|
bool occurs(expr const & n, context const & c) { return occurs(n, &c, 0, nullptr); }
|
|
bool occurs(name const & n, context const & c) { return occurs(n, &c, 0, nullptr); }
|
|
bool occurs(expr const & n, context const & c, unsigned sz, expr const * es) { return occurs(n, &c, sz, es); }
|
|
bool occurs(name const & n, context const & c, unsigned sz, expr const * es) { return occurs(n, &c, sz, es); }
|
|
}
|