michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(node): report render error to the terminal (#8599)

Browse source
This commit is contained in:
Arsh 2023-09-20 13:57:46 +05:30 committed by GitHub
parent 1f1c47d909
commit 2e1d5f8739
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/curly-icons-watch.md Normal file
View file

@ -0,0 +1,5 @@
---
'@astrojs/node': patch
---
The node adapter now logs uncaught errors encountered during rendering a page.

3
packages/integrations/node/src/nodeMiddleware.ts
View file

@ -51,6 +51,9 @@ export default function (app: NodeApp, mode: Options['mode']) {
await writeWebResponse(app, res, response); await writeWebResponse(app, res, response);
} }
} catch (err: unknown) { } catch (err: unknown) {
const logger = app.getAdapterLogger()
logger.error(`Could not render ${req.url}`)
console.error(err)
if (!res.headersSent) { if (!res.headersSent) {
res.writeHead(500, `Server error`); res.writeHead(500, `Server error`);
res.end(); res.end();