michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

code review comments

Browse source
This commit is contained in:
Fred K. Schott 2021-07-13 10:57:40 -04:00
parent 3f14bed413
commit 4b1f5c3dc6
24 changed files with 23 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
.changeset/lovely-kids-sniff.md
View file

@ -1,17 +0,0 @@
---
'@example/blog': minor
'@example/blog-multiple-authors': minor
'@example/docs': minor
'@example/framework-multiple': minor
'@example/framework-preact': minor
'@example/framework-react': minor
'@example/framework-svelte': minor
'@example/framework-vue': minor
'@example/portfolio': minor
'@example/snowpack': minor
'@example/with-markdown': minor
'@example/with-markdown-plugins': minor
'@example/with-tailwindcss': minor
---
Add lang attribute to html tags

3
examples/blog-multiple-authors/src/pages/$author.astro
View file

@ -8,7 +8,6 @@ import Pagination from '../components/Pagination.astro';
let title = 'Don’s Blog'; let title = 'Don’s Blog';
let description = 'An example blog on Astro'; let description = 'An example blog on Astro';
let canonicalURL = Astro.request.canonicalURL; let canonicalURL = Astro.request.canonicalURL;
let lang = 'en';
// collection // collection
import authorData from '../data/authors.json'; import authorData from '../data/authors.json';
@ -46,7 +45,7 @@ export async function createCollection() {
const author = authorData[collection.params.author]; const author = authorData[collection.params.author];
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<title>{title}</title> <title>{title}</title>
<MainHead <MainHead

3
examples/blog-multiple-authors/src/pages/$posts.astro
View file

@ -8,7 +8,6 @@ import Pagination from '../components/Pagination.astro';
let title = 'Don’s Blog'; let title = 'Don’s Blog';
let description = 'An example blog on Astro'; let description = 'An example blog on Astro';
let canonicalURL = Astro.request.canonicalURL; let canonicalURL = Astro.request.canonicalURL;
let lang = 'en';
// collection // collection
import authorData from '../data/authors.json'; import authorData from '../data/authors.json';
@ -39,7 +38,7 @@ export async function createCollection() {
} }
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<title>{title}</title> <title>{title}</title>
<MainHead <MainHead

3
examples/blog-multiple-authors/src/pages/about.astro
View file

@ -3,9 +3,8 @@ import MainHead from '../components/MainHead.astro';
import Nav from '../components/Nav.astro'; import Nav from '../components/Nav.astro';
let title = "About"; let title = "About";
let lang = 'en';
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<MainHead <MainHead
title={title} title={title}

3
examples/blog-multiple-authors/src/pages/index.astro
View file

@ -12,7 +12,6 @@ import authorData from '../data/authors.json';
// All variables are available to use in the HTML template below. // All variables are available to use in the HTML template below.
let title = 'Don’s Blog'; let title = 'Don’s Blog';
let description = 'An example blog on Astro'; let description = 'An example blog on Astro';
let lang = 'en';
// Data Fetching: List all Markdown posts in the repo. // Data Fetching: List all Markdown posts in the repo.
let allPosts = Astro.fetchContent('./post/*.md'); let allPosts = Astro.fetchContent('./post/*.md');
@ -22,7 +21,7 @@ let firstPage = allPosts.slice(0, 2);
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<title>{title}</title> <title>{title}</title>
<MainHead <MainHead

3
examples/blog/src/pages/index.astro
View file

@ -11,7 +11,6 @@ import BlogPostPreview from '../components/BlogPostPreview.astro';
let title = 'Example Blog'; let title = 'Example Blog';
let description = 'The perfect starter for your perfect blog.'; let description = 'The perfect starter for your perfect blog.';
let permalink = 'https://example.com/'; let permalink = 'https://example.com/';
let lang = 'en';
// Data Fetching: List all Markdown posts in the repo. // Data Fetching: List all Markdown posts in the repo.
let allPosts = Astro.fetchContent('./posts/*.md'); let allPosts = Astro.fetchContent('./posts/*.md');
@ -20,7 +19,7 @@ allPosts = allPosts.sort((a, b) => new Date(b.publishDate) - new Date(a.publishD
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink={permalink} /> <BaseHead title={title} description={description} permalink={permalink} />
<link rel="stylesheet" href="/blog.css" /> <link rel="stylesheet" href="/blog.css" />

3
examples/framework-multiple/src/pages/index.astro
View file

@ -6,12 +6,11 @@ import { PreactCounter } from '../components/PreactCounter.tsx';
import VueCounter from '../components/VueCounter.vue'; import VueCounter from '../components/VueCounter.vue';
import SvelteCounter from '../components/SvelteCounter.svelte'; import SvelteCounter from '../components/SvelteCounter.svelte';
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" /> <meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" />

3
examples/framework-preact/src/pages/index.astro
View file

@ -2,12 +2,11 @@
// Component Imports // Component Imports
import Counter from '../components/Counter.jsx' import Counter from '../components/Counter.jsx'
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<meta <meta

3
examples/framework-react/src/pages/index.astro
View file

@ -2,12 +2,11 @@
// Component Imports // Component Imports
import Counter from '../components/Counter.jsx' import Counter from '../components/Counter.jsx'
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<meta <meta

3
examples/framework-svelte/src/pages/index.astro
View file

@ -2,12 +2,11 @@
// Component Imports // Component Imports
import Counter from '../components/Counter.svelte' import Counter from '../components/Counter.svelte'
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<meta <meta

3
examples/framework-vue/src/pages/index.astro
View file

@ -2,12 +2,11 @@
// Component Imports // Component Imports
import Counter from '../components/Counter.vue' import Counter from '../components/Counter.vue'
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<meta <meta

3
examples/portfolio/src/pages/$projects.astro
View file

@ -5,7 +5,6 @@ import Nav from '../components/Nav/index.jsx';
import PortfolioPreview from '../components/PortfolioPreview/index.jsx'; import PortfolioPreview from '../components/PortfolioPreview/index.jsx';
let { collection } = Astro.props; let { collection } = Astro.props;
let lang = 'en';
export async function createCollection() { export async function createCollection() {
return { return {
async data() { async data() {
@ -17,7 +16,7 @@ export async function createCollection() {
} }
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<MainHead title="All Projects | Jeanine White" /> <MainHead title="All Projects | Jeanine White" />
<style lang="scss"> <style lang="scss">

3
examples/portfolio/src/pages/404.astro
View file

@ -3,10 +3,9 @@ import MainHead from '../components/MainHead.astro';
import Footer from '../components/Footer/index.jsx'; import Footer from '../components/Footer/index.jsx';
import Nav from '../components/Nav/index.jsx'; import Nav from '../components/Nav/index.jsx';
let lang = 'en';
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<MainHead title="Not Found" /> <MainHead title="Not Found" />
</head> </head>

3
examples/portfolio/src/pages/about.astro
View file

@ -3,10 +3,9 @@ import MainHead from '../components/MainHead.astro';
import Footer from '../components/Footer/index.jsx'; import Footer from '../components/Footer/index.jsx';
import Nav from '../components/Nav/index.jsx'; import Nav from '../components/Nav/index.jsx';
let lang = 'en';
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<MainHead title="About | Jeanine White" /> <MainHead title="About | Jeanine White" />
<style lang="scss"> <style lang="scss">

3
examples/portfolio/src/pages/index.astro
View file

@ -9,12 +9,11 @@ import PorfolioPreview from '../components/PortfolioPreview/index.jsx';
// Data Fetching: List all Markdown posts in the repo. // Data Fetching: List all Markdown posts in the repo.
const projects = Astro.fetchContent('./project/**/*.md'); const projects = Astro.fetchContent('./project/**/*.md');
const featuredProject = projects[0]; const featuredProject = projects[0];
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<MainHead title="Jeanine White: Personal Site" /> <MainHead title="Jeanine White: Personal Site" />
<style lang="scss"> <style lang="scss">

3
examples/snowpack/src/pages/404.astro
View file

@ -4,11 +4,10 @@ import MainLayout from '../components/MainLayout.astro';
let title = 'Not Found'; let title = 'Not Found';
let description = 'Snowpack is a lightning-fast frontend build tool, designed for the modern web.'; let description = 'Snowpack is a lightning-fast frontend build tool, designed for the modern web.';
let lang = 'en';
--- ---
<!doctype html> <!doctype html>
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink="TODO" /> <BaseHead title={title} description={description} permalink="TODO" />

3
examples/snowpack/src/pages/guides.astro
View file

@ -23,7 +23,6 @@ let title = 'Guides';
let description = 'Snowpack\'s usage and integration guides.'; let description = 'Snowpack\'s usage and integration guides.';
let guides; let guides;
let communityGuides; let communityGuides;
let lang = 'en';
guides = paginate({ guides = paginate({
files: '/posts/guides/*.md', files: '/posts/guides/*.md',
@ -41,7 +40,7 @@ let lang = 'en';
--- ---
<!doctype html> <!doctype html>
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink="TODO" /> <BaseHead title={title} description={description} permalink="TODO" />

3
examples/snowpack/src/pages/index.astro
View file

@ -7,11 +7,10 @@ import BaseLayout from '../components/BaseLayout.astro';
let title = 'Snowpack'; let title = 'Snowpack';
let description = 'Snowpack is a lightning-fast frontend build tool, designed for the modern web.'; let description = 'Snowpack is a lightning-fast frontend build tool, designed for the modern web.';
let lang = 'en';
--- ---
<!doctype html> <!doctype html>
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<style lang="scss"> <style lang="scss">
@use '../../public/styles/var' as *; @use '../../public/styles/var' as *;

3
examples/snowpack/src/pages/news.astro
View file

@ -14,11 +14,10 @@ import users from '../data/users.json';
const title = 'Community & News'; const title = 'Community & News';
const description = 'Snowpack community news and companies that use Snowpack.'; const description = 'Snowpack community news and companies that use Snowpack.';
let lang = 'en';
--- ---
<!doctype html> <!doctype html>
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink="TODO" /> <BaseHead title={title} description={description} permalink="TODO" />

3
examples/snowpack/src/pages/plugins.astro
View file

@ -5,11 +5,10 @@ import MainLayout from '../components/MainLayout.astro';
let title = 'The Snowpack Plugin Catalog'; let title = 'The Snowpack Plugin Catalog';
let description = 'Snowpack plugins allow for configuration-minimal tooling integration.'; let description = 'Snowpack plugins allow for configuration-minimal tooling integration.';
let lang = 'en';
--- ---
<!doctype html> <!doctype html>
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink="TODO" /> <BaseHead title={title} description={description} permalink="TODO" />

3
examples/snowpack/src/pages/proof-of-concept-dynamic/[slug].astro.ignore
View file

@ -8,7 +8,6 @@ import BaseLayout from '../components/BaseLayout.astro';
let title = 'Community & News'; let title = 'Community & News';
let description = 'Snowpack community news and companies that use Snowpack.'; let description = 'Snowpack community news and companies that use Snowpack.';
let entry; let entry;
let lang = 'en';
export default async function ({ params }) { export default async function ({ params }) {
entry = await contentful.getEntry(params.slug); entry = await contentful.getEntry(params.slug);
@ -16,7 +15,7 @@ export default async function ({ params }) {
} }
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<BaseHead title={title} description={description} permalink="TODO" /> <BaseHead title={title} description={description} permalink="TODO" />

3
examples/starter/src/pages/index.astro
View file

@ -9,12 +9,11 @@ import Tour from '../components/Tour.astro';
// It will run during the build, but never in the browser. // It will run during the build, but never in the browser.
// All variables are available to use in the HTML template below. // All variables are available to use in the HTML template below.
let title = 'My Astro Site'; let title = 'My Astro Site';
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="UTF-8"> <meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1"> <meta name="viewport" content="width=device-width, initial-scale=1">

3
examples/with-nanostores/src/pages/index.astro
View file

@ -5,11 +5,10 @@ import AdminsSvelte from '../components/AdminsSvelte.svelte';
import AdminsVue from '../components/AdminsVue.vue'; import AdminsVue from '../components/AdminsVue.vue';
import AdminsPreact from '../components/AdminsPreact.jsx'; import AdminsPreact from '../components/AdminsPreact.jsx';
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="UTF-8"> <meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1"> <meta name="viewport" content="width=device-width, initial-scale=1">

3
examples/with-tailwindcss/src/pages/index.astro
View file

@ -2,11 +2,10 @@
// Component Imports // Component Imports
import Button from '../components/Button.astro'; import Button from '../components/Button.astro';
let lang = 'en';
// Full Astro Component Syntax: // Full Astro Component Syntax:
// https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md // https://github.com/snowpackjs/astro/blob/main/docs/core-concepts/astro-components.md
--- ---
<html lang={ lang ?? 'en' }> <html lang="en">
<head> <head>
<meta charset="UTF-8" /> <meta charset="UTF-8" />
<title>Astro + TailwindCSS</title> <title>Astro + TailwindCSS</title>