Commit graph

4178 commits

Author SHA1 Message Date
Matthew Phillips
45758451ee Add another change to test if the review happens twice 2022-09-23 09:35:44 -04:00
Matthew Phillips
79d036513e empty string 2022-09-23 09:32:33 -04:00
Matthew Phillips
cf5cffe2be strings 2022-09-23 09:24:53 -04:00
Matthew Phillips
3ce3370c38 only run if not already blocked 2022-09-23 09:20:13 -04:00
Matthew Phillips
c8fef3e3ae wrap the contents maybe 2022-09-23 09:15:22 -04:00
Matthew Phillips
267ba4d113 echo the count of blocked reviews 2022-09-23 09:11:21 -04:00
Matthew Phillips
eba1323050 should be a number 2022-09-23 08:55:53 -04:00
Matthew Phillips
226fa15a79 check if the bot left a review 2022-09-23 08:51:10 -04:00
Matthew Phillips
bb54cc3bd9 echo the raw content 2022-09-23 08:45:25 -04:00
Matthew Phillips
80a669765c debug, get current reviews 2022-09-23 08:44:27 -04:00
Matthew Phillips
971559dd11 better json 2022-09-23 08:25:28 -04:00
Matthew Phillips
a197189a26 should be issues 2022-09-23 08:19:56 -04:00
Matthew Phillips
e08fb43336 try again 2022-09-23 08:16:09 -04:00
Matthew Phillips
fa3960e664 remove old one 2022-09-23 08:15:01 -04:00
Matthew Phillips
9fce6f4821 some more testing 2022-09-23 08:14:21 -04:00
Matthew Phillips
6c17cdca45 verify patch doesn't trigger it 2022-09-22 17:02:47 -04:00
Matthew Phillips
02b4664c70 maybe fixed 2022-09-22 17:01:48 -04:00
Matthew Phillips
64f72d6cf2 try fetch-depth: 2 2022-09-22 17:01:12 -04:00
Matthew Phillips
0b66dd9913 debugging 2022-09-22 16:54:40 -04:00
Matthew Phillips
eecff58bbc Make it be minor 2022-09-22 16:52:31 -04:00
Matthew Phillips
c590adc9c1 Add a patch changeset 2022-09-22 16:50:40 -04:00
Matthew Phillips
66c9a11210 Use outputs 2022-09-22 16:47:57 -04:00
Matthew Phillips
511485fdc6 Fix the if condition 2022-09-22 16:39:10 -04:00
Matthew Phillips
e515100f8c list files 2022-09-22 16:36:28 -04:00
Matthew Phillips
a7e200ef11 add checkout 2022-09-22 16:34:34 -04:00
Matthew Phillips
a66497202d fix formatting 2022-09-22 16:31:49 -04:00
Matthew Phillips
1bd3c29aa6 fix yaml error 2022-09-22 16:26:47 -04:00
Matthew Phillips
5807402348 Testing if there's a changed file 2022-09-22 16:23:04 -04:00
Matthew Phillips
d37f02b80a Try again 2022-09-22 15:39:39 -04:00
Matthew Phillips
a6d53e06fe Block a merge when the PR is marked as minor 2022-09-22 15:22:56 -04:00
Bjorn Lu
6a1a17dd28
Add CSS @import test (#4454)
* Add css hmr test

* Allow HMR in e2e tests

* Add changeset

* Actually fix test

* Fix lint

* Skip windows for now
2022-09-22 15:06:49 -04:00
matthewp
5e568e4a14 [ci] format 2022-09-22 19:05:57 +00:00
Happydev
08dae16161
feat(vite-plugin-markdown): support importing markdown files from outside root project (#4780)
* feat: support importing markdown from outside root project

This change adds support for importing markdown located outside the root of directory of a project

* refactor how the "jsx-runtime" module path is retrieved

* refactor: split type imports and function import

Pattern I've seen repeated a lot in the repo

* fix: chaotic marge conflict mistake

Co-authored-by: Matthew Phillips <matthew@skypack.dev>
2022-09-22 15:04:03 -04:00
Tobias
9fb03b2e99
examples rss: add mdx file ending (#4710)
This follows the same pattern used in https://github.com/withastro/astro/blob/main/examples/blog/src/pages/blog.astro#L8. Without adding `mdx` here, only some blog posts will be part of the rss.xml file.
2022-09-22 14:53:07 -04:00
matthewp
d2853ebe66 [ci] format 2022-09-22 18:50:12 +00:00
Zicklag
5e4c5252bd
Http proxy for fetch (#4676)
* Add HTTP Proxy Support to `fetch` Polyfill

Use `global-agent` to support HTTP_PROXY, HTTPS_PROXY, and NO_PROXY
environment variables.

* Add Changeset For HTTP Proxy Support in `fetch`
2022-09-22 14:47:06 -04:00
matthewp
6ce8ae261f [ci] format 2022-09-22 18:39:14 +00:00
Michael Rienstra
7481ffda02
create-astro: always create tsconfig.json (#4810)
* `create-astro`: always create `tsconfig.json`

Currently, we only make sure `tsconfig.json` exists when `strict` or `strictest` is selected. Both `default` & `optout` are intended to correspond to `base` -- and will do so for all [23 official templates](https://github.com/withastro/astro/tree/main/examples), but not necessarily for third-party templates.

The [example command for installing a third-party template](https://github.com/withastro/astro/blob/a800bf7/packages/create-astro/README.md?plain=1#L31-L35) is (rather conveniently for the sake of this PR!) an example of a template without a `tsconfig.json` file, and installing it with the `default` ("Relaxed") Typescript option results in no `tsconfig.json` file, rather than a `tsconfig.json` file containing `{ "extends": "astro/tsconfigs/base" }` as would be expected.

This PR addresses this scenario. 

It also explicitly sets the `tsconfig.json` file to `{ "extends": "astro/tsconfigs/base" }` when `default` (which I renamed to `base`, still presented to the user as "Relaxed") or `optout` is selected (`optout` has always printed a warning about the importance of `tsconfig.json` & `src/env.d.ts` but otherwise behaved identically to `default`). This is necessary in two scenarios:

1. When the `tsconfig.json` file was created by this script.
2. When it either didn't already include `"extends"`, or it extended a different config by default. For example, some third-party templates might default to `strict`, in which case I'm guessing we'd want to respect the user's choice and change that to `base`.

* update `del` 6.1.1 --> 7.0.0

* test: prevent excess writes
(without this it triggers many times)

* test: create-astro typescript prompt

* changeset

* fix: recursive `mkdirSync`

* test: longer timeout for `windows-latest` OS
(see if this fixes failing tests)

* better glob path creation, don't hardcode `/`

* test: longer timeout for windows-latest OS
(since I'm about to trigger another CI run by pushing a commit, might as well try this too)

* create-astro test: show last CLI output on timeout

* drop variable timeout
Typescript tests are slower than directory tests, but they are all usually less than 5000 ms. Less complexity, easier to maintain.

* DRY new error output

* Update lockfile

* Sync lockfile with main

* Update lockfile

Co-authored-by: Princesseuh <princssdev@gmail.com>
2022-09-22 14:37:01 -04:00
Ben Holmes
e5f71142eb
docs: add MDXLayoutProps to README (#4700)
* docs: add MDXLayoutProps to README

* chore: changeset

* nit: remove "if you understand this diff"

* nit: AdD tYpE sAfEtY

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>

* Update packages/integrations/mdx/README.md

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
2022-09-22 14:35:37 -04:00
梁峰宁
17dbc67018
Fix slashes for paths containing non-ASCII characters on Windows. (#4712)
* Fix slashes for paths containing non-ASCII characters on Windows.

* Add non-ASCII path test

* Fix slashes in pnpm-lock.yaml
2022-09-22 14:33:28 -04:00
Erika
e9eb4d1f3d
Fix ESLint not working in CI (#4837)
* Update ESLint extensions

* Use fredkbot

* Only use fredkbot for the commit

* Disable autofix

* Fix lint error
2022-09-22 11:37:41 -04:00
Fred K. Bot
47d4165603
[ci] release (#4833)
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2022-09-22 11:04:45 -04:00
Fred K. Bot
49c6eb8b8a
[ci] update lockfile (#4839)
Co-authored-by: FredKSchott <FredKSchott@users.noreply.github.com>
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
2022-09-22 10:55:39 -04:00
Matthew Phillips
25a5b9a89a
Revert preact signals support (#4843)
* Revert "Update preact example to match @astrojs/preact ranges (#4840)"

This reverts commit d650a1161a.

* Revert "[ci] format"

This reverts commit e3c78c5b16.

* Revert "Support shared signals in Preact islands (#4763)"

This reverts commit 5e46be5468.
2022-09-22 10:32:42 -04:00
Matthew Phillips
d650a1161a
Update preact example to match @astrojs/preact ranges (#4840) 2022-09-22 08:37:38 -04:00
Michael Rienstra
b0efb83252
docs: integrations: yarn & pnpm (#4836) 2022-09-22 08:16:02 -03:00
Brett Jankord
2c2bbc5158
Update blog post date text color to meet contrast-ratio guidelines (#4821) 2022-09-22 15:18:09 +08:00
matthewp
778dce8c05 [ci] format 2022-09-21 23:09:40 +00:00
Matthew Phillips
73f215df76
Allow passing fetch() Response to set:html (#4832)
* ALlow passing fetch() Response to set:html

* Only check for Symbol.iterator on objects

* oops

* Fix no-streaming case

* Remove old comment
2022-09-21 19:07:00 -04:00
matthewp
b4c5c8ef57 [ci] format 2022-09-21 19:56:15 +00:00