michael/astro
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
astro/.changeset/wicked-laws-heal.md
Emmanuel Chucks ed2dfdae5b
fix: updates <Picture /> to pass HTML attributes down to the <img /> element (#5038) 
* fix: also pass attrs to underlying img

`class` for direct img styling, `width` & `height` to prevent layout shift, etc need to be passed to the underlying img tag to work.

* remove redundant attr from picture tag

* revert to previous commit

- seemed to break some tests
- can't deal with fixing that right now, maybe later

* only passing attributes to the img

* adding a note to the README

* chore: add changeset

Co-authored-by: Tony Sullivan <tony.f.sullivan@outlook.com>
2022-10-20 19:42:36 +00:00

485 B
Raw Blame History

@astrojs/image
minor

HTML attributes included on the <Picture /> component are now passed down to the underlying <img /> element.

Why?

  • when styling a <picture> the class and style attributes belong on the <img> itself
  • <picture> elements should not actually provide any aria- attributes
  • width and height can be added to the <img> to help prevent layout shift